search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

add flags for press keycodes #556

Closed KazuCocoa closed 5 years ago

KazuCocoa commented 5 years ago

http://appium.io/docs/en/commands/device/keys/press-keycode/ http://appium.io/docs/en/commands/device/keys/long-press-keycode/

pressKeycode and longPressKeycode should support flags to catch up with the latest spec.

We can pass multiple key flags as one number using bit operator, OR.

cc @dpgraham @jlipps

KazuCocoa commented 5 years ago

Except for unit test, CI failed because of Could not start Sauce Connect. Exit code 1 signal: null

admc commented 5 years ago

Thanks!

jlipps commented 5 years ago

@admc did you mean to merge this?

admc commented 5 years ago

Said that you approved the changes, so I pulled and ran tests and they all passed - you think we should back it out?

jlipps commented 5 years ago

Oh I was asking because you closed this instead of merging it.

admc commented 5 years ago

Woops, meant to merge, then comment. Sorry everyone!