search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 402 forks source link

[WIP][#555] Update request dependency #561

Closed mattrayner closed 5 years ago

mattrayner commented 5 years ago
mattrayner commented 5 years ago

@admc I've updated the dependency to 2.88 and npm test passes - I've run gulp test but am getting some Firefox issues - I think they're related to my setup though, rather than actual test failures, I'd very much appreciate a steer from you? I'm not confident my machine is set up correctly :-1:

mattrayner commented 5 years ago

As an aside, the failing travis scripts seem to be related to a sauce connect issue

admc commented 5 years ago

Thanks for digging in. I'm actually getting an error running "gulp test-midway-chrome" - could you take a look? I also get firefox failing, and I think thats because something changed in the firefox driver with new versions of firefox, I would also love to get that fixed. The reason the branches are failing has to do with the shared secrets for running sauce connect on travis.. I don't know if there is a better way to do that now or not.

mattrayner commented 5 years ago

The Firefox issue might be related to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1486909

mattrayner commented 5 years ago

The chrome issues seem to be related to calls to Q.all

mattrayner commented 5 years ago

@admc I've updated my PR with a fix for gulp test-midway-chrome - it includes some logging stuff which can be ignored - what would the impact be for removing calls to Q.all?

My 'fix' was to remove extra calls that didn't appear to be related to the method a given test was running against. I don't have the back ground understanding of the individual tests to know if this was smart or not...

mattrayner commented 5 years ago

Regarding SauceConnect - it looks like it's free for open source https://saucelabs.com/open-source so it should be a case of creating an account and following the steps detailed in the travis docs https://docs.travis-ci.com/user/gui-and-headless-browsers/

I'm not sure if this was originally set up and has broken over time? I think you need to be repo admin to add it to SauceLabs

admc commented 5 years ago

Thanks!