search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 404 forks source link

fix: destroy keep-alive sockets on quit #613

Closed imurchie closed 4 years ago

imurchie commented 4 years ago

Try to destroy the http agent's sockets when quit is called, to avoid hanging until they close on their own.

Cc: @vrunoa

vrunoa commented 4 years ago

@imurchie was this the cause on travis failing?

imurchie commented 4 years ago

@vrunoa It fixes the hanging on my local driver tests. But locally the appium e2e tests still fail. :(

imurchie commented 4 years ago

Hmm. In tests that exit in ways other than driver.quit (e.g., timeouts) this does not work.

imurchie commented 4 years ago

So, for instance, this test causes a hang since the title call is outside of the bounds of init/quit.

Not sure how to handle this.