revert keep-alive until someone figures out how to fix it

admc / wd

A node.js client for webdriver/selenium 2.

Other

1.53k stars 404 forks source link

revert keep-alive until someone figures out how to fix it #615

Closed imurchie closed 4 years ago

imurchie commented 4 years ago

Having keep-alive sockets causes session close to hang. Until someone makes a general solution to this, I don't think this should be here. Perhaps it could be configurable in driver.init?

imurchie commented 4 years ago

@jlipps When you have a chance can you publish this?

imurchie commented 4 years ago

@jlipps Actually, hold off on that. I might have a server-side solution that works.

imurchie commented 4 years ago

Published https://github.com/appium/appium-base-driver/pull/382 and waiting for it to get through Appium's build, to see if it fixes things.

imurchie commented 4 years ago

appium-base-driver@5.2.1 seems to have fixed it from the server side. I will open a PR to revert this reversion.