search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 404 forks source link

refactor: revert back to keep-alive sockets #616

Closed imurchie closed 4 years ago

imurchie commented 4 years ago

The Appium server has been fixed to handle keep-alive sockets.

jlipps commented 4 years ago

does this have any consequences for selenium?

imurchie commented 4 years ago

Ugh. I keep finding new conditions where the keepalive socket messes things up. I don't have time to figure them all out, and figure out if it will mess up other systems.

I say skip this, and publish from master to get rid of them.

imurchie commented 4 years ago

Perhaps either the option can be added to the initialization of wd, or a function can be added to set it on an initialized instance. Then it would be opt-in.