admin-ch / CovidCertificate-App-iOS

CovidCertificate Apps for iOS
Mozilla Public License 2.0
110 stars 21 forks source link

Correct Display the Booster Vaccination not as Incomplete #247

Closed ojehle closed 2 years ago

ojehle commented 2 years ago

Swiss Covid App shows Booster Vaccinations as Incomplete Vaccinations in my certificate i have 3 doses of a total of 2 needed.

I expect the same on the android version

diff --git a/Wallet/Screens/Certificates/CertificateDetailView.swift b/Wallet/Screens/Certificates/CertificateDetailView.swift index ebfb2d9..4c89e1d 100644 --- a/Wallet/Screens/Certificates/CertificateDetailView.swift +++ b/Wallet/Screens/Certificates/CertificateDetailView.swift @@ -81,7 +81,7 @@ class CertificateDetailView: UIView {

     addDividerLine()
ojehle commented 2 years ago

not shure if doseNumber and totalDoses must be switched equal or less ..... but anyway.. it looks like the booster makes the number of doses applied higher, but the fixed number 2 (for moderna/pfizer) will stay on the certificate. in my case 3/2.

goebelUB commented 2 years ago

Thanks for reporting! This seems to be a UI issue in the wallet. Even though we show the wrong strings (e.g. the title "Vaccination incomplete"), the certificate itself should still be shown as valid (blue box with "Only valid with an identity document").

Could you please check that your cert is also shown green in the verifier (Covid Check)?

On a side note: as far as I know booster certs should be issued as 3/3. Is this a Swiss certificate?

ojehle commented 2 years ago

It's a certificate from liechtenstein...

It's valid in both apps.

the certificate is valid - green with the check app.
and valid with document in the blue app.

but i think it's still correct the information in the certificate. because for moderna you need 2 doses that it's valid. the booster is recommended, but not a must.

I was not sure if the totalDoses or doseNumber is the "must" have dose.. anyway.. if the amount of injections i got is higher then the one i must have, it should be not shown as "incomplete"...