admin-ch / CovidCertificate-SDK-iOS

CovidCertificate SDK for iOS
Mozilla Public License 2.0
19 stars 7 forks source link

Feature: Improve offline mode vs. time inconsistency #116

Closed UBaggeler closed 2 years ago

UBaggeler commented 2 years ago

This pull-request changes the network error handling. Assuming that AWS infrastructure is nearly always available, we will get an HTTP error (status code != 2xx) if BIT infrastructure is not available. With this change, force-refresh will only use cached data if BIT's infrastructure is not available but fail for other network errors (e.g. Airplane mode,...).

github-actions[bot] commented 2 years ago

Unit Test Results

  1 files  ±0    1 suites  ±0   9s :stopwatch: ±0s 36 tests ±0  36 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 95d230d9. ± Comparison against base commit 95d230d9.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication