search

admin-shell-io / aas-test-engines

Official test tooling for the Asset Administration Shell
https://certification.admin-shell-io.com
Apache License 2.0
5 stars 2 forks source link

Optional but empty arrays are considered an error #15

Closed otto-ifak closed 3 weeks ago

otto-ifak commented 2 months ago

Currently, arrays which are optional (i.e. not required) are considered as an error when present but empty. Eg:

{
  "conceptDescriptions": []
}

is currently rejected.

We need to clarify if this is compliant to the spec.

otto-ifak commented 2 months ago

See also https://github.com/admin-shell-io/aas-test-engines/issues/13#issuecomment-2044698045

otto-ifak commented 2 months ago

I would argue for removing minItems: 1 from https://github.com/admin-shell-io/aas-test-engines/blob/main/aas_test_engines/data/file/3.0.yml then (currently 28 instances)

sebbader-sap commented 2 months ago

The desired behaviour, as agreed in the AAS Specification working group, is that no empty conceptDescriptions array is present. Therefore, the minItems: 1 clauses are correct.

sebbader-sap commented 2 months ago

We need to clarify if this is compliant to the spec.

It is :-)

otto-ifak commented 1 month ago

Great, thanks @sebbader-sap for clarifying this!

juileetikekar commented 1 month ago

Related issue in the specifications, https://github.com/admin-shell-io/aas-specs/issues/418