Closed sebbader-sap closed 9 months ago
@matgnt can you please check the current state of the PR? Would be great if we get at least one review from an independent party :-).
@matgnt can you please check the current state of the PR? Would be great if we get at least one review from an independent party :-).
I did add 1 comment with the Dataspace example.
In general, I think it is very difficult for users / developers to understand the difference between repository vs. pure submodel and when to add /submodel
and when not and what to expect from those endpoints and consequently to add /$value
in some (most) cases.
In general my preferred solution would be, that:
$value
ONLYhref
without any further meaning, you just get the data from there (no fixed term /submodel
)I think whenever the semantics of the content from such and endpoint is known from the enclosing context semanticId
, this would be the straight forward way that I would expect as a developer.
See comments
One bug: protocol versions are an array
Indeed, I have changed the lines.
@BirgitBoss and @matgnt I have finally integrated your comments. Let's get this done as soon as possible (this year?).
Merging now, even though some reviews are still open. If needed, content can be adjusted later.
👏 thanks everyone for the efforts! great work!
Solves #89