Multiple Constraint Violations in Time-Series Data Submodel

[zrgt]

I encountered several constraint violations when attempting to open the Time-Series Data Submodel template:

• The dataSpecification mandatory attribute is missing in multiple embeddedDataSpecifications.
• Several shortNames of dataSpecificationIec61360 exceed the length limit of 18 characters.
• Some mandatory shortNames of dataSpecificationIec61360 are not set.

[Rudra-sandeep]

@zrgt Please use the latest JSON file of the respective SMT which as been uploaded yesterday

[zrgt]

@Rudra-sandeep the JSON has still problems:

• Properties with different valueTypes have a value='' which is not None, it is string. In cases where valueType is not string it causes errors. Now:

              {
                "category": "VARIABLE",
                "idShort": "RecordCount",
                "semanticId": {
                  "type": "ExternalReference",
                  "keys": [
                    {
                      "type": "GlobalReference",
                      "value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
                    }
                  ]
                },
                "qualifiers": [
                  {
                    "type": "Cardinality",
                    "valueType": "xs:string",
                    "value": "ZeroToOne"
                  }
                ],
                "valueType": "xs:long",
                "value": "",
                "modelType": "Property"
              }

Should be:

                {
                  "category": "VARIABLE",
                  "idShort": "RecordCount",
                  "semanticId": {
                    "type": "ExternalReference",
                    "keys": [
                      {
                        "type": "GlobalReference",
                        "value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
                      }
                    ]
                  },
                  "qualifiers": [
                    {
                      "type": "Cardinality",
                      "valueType": "xs:string",
                      "value": "ZeroToOne"
                    }
                  ],
                  "valueType": "xs:long",
                  "modelType": "Property"
                }

• Also in cases where valueType is string and value is not set the value key should be just removed from property object.
• File object also has an empty string as a value: "value": "". This also should be removed.

Tested with https://github.com/rwth-iat/basyx-python-sdk

[zrgt]

The problem also occures in Range object, as it has min and max values which should be removed or set to valid XSD datetime string

{
                "idShort": "Timespan",
                "description": [
                  {
                    "language": "en",
                    "text": "The valueType of the given timespan must match the valueType of the time properties of the segments."
                  }
                ],
                "semanticId": {
                  "type": "ExternalReference",
                  "keys": [
                    {
                      "type": "GlobalReference",
                      "value": "https://admin-shell.io/idta/TimeSeries/Timespan/1/1"
                    }
                  ]
                },
                "valueType": "xs:dateTime",
                "min": "",
                "max": "",
                "modelType": "Range"
              }

The same proble appears in DataSpecificationIec61360 with value:

{
            "preferredName": [
              {
                "language": "de",
                "text": "Zeitreihen Metadaten"
              },
              {
                "language": "en",
                "text": "time series metadata"
              }
            ],
            "shortName": [
              {
                "language": "de",
                "text": "Metadaten"
              },
              {
                "language": "en",
                "text": "metadata"
              }
            ],
            "definition": [
              {
                "language": "de",
                "text": "Eine Reihe von Daten, welche die Zeitreihe beschreiben und \u00FCber sie Auskunft geben"
              },
              {
                "language": "en",
                "text": "A set of data describing and providing information about the time series"
              }
            ],
            "value": "",
            "modelType": "DataSpecificationIec61360"
          }

[zrgt]

Also a problem in ExternalReference in semantiid of segments. According to Constraint AASd-122 the type of the first key of an ExternalReference must be a GenericGloballyIdentifiable, but "Property" was set:

            {
              "value": {
                "idShort": "Segments",
                "semanticId": {
                  "type": "ExternalReference",
                  "keys": [
                    {
                      "type": "Property",
                      "value": "https://admin-shell.io/idta/TimeSeries/AggregationMethod/1/1"
                    }
                  ]
                },
                "modelType": "SubmodelElementCollection"
              }
            }

[Rudra-sandeep]

@zrgt Thank you for your feedback I will look into this issues.

[zrgt]

@Rudra-sandeep the same problems mentioned in the original issue report also appear in JSON.

[zrgt]

@zrgt Thank you for your feedback, I will look into this issue.

@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.

[Rudra-sandeep]

@zrgt Thank you for your feedback, I will look into this issue.

@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.

@zrgt Yes regarding to compliant with the Spec we have already started discussions in the WG's