search

admin-shell-io / submodel-templates

Submodel Templates for AAS
Creative Commons Attribution 4.0 International
45 stars 16 forks source link

Proposal: Streamlining of Modelling practice in: Provision of 3D Models #86

Open mwly opened 1 month ago

mwly commented 1 month ago

Hi in #85 I voiced my confusion about how the modelling of Provision of 3dModels. It did not let me go so I dug deep into the metamodel and tried to find out what led to this way of modelling and I believe with more intuitive naming the problem could be helped.

My Proposal is to rename some Entities and Change the way Submodel Element Lists are documented in this template.

The Issue that I have with the naming right now is:

  1. The ID short of the submodel does not match the actual name of the Submodel. This creates confusion and also blocks the name "simpler" name to be used when an Entity actually describes that "simpler" thing.
  2. A Container should be named in a way that makes you undestand what it contains. eg. the list Model3D does not contain a model but can contain multiple. So it should be called Models3D.
  3. The Tables for SMLs in this specification take a shortcut by skipping to describe its childs. Instead they desribe the childs of the child, which leads to multiple problems. For one applicants now dont know what semantic ID to give the childs. Same goes for the explanation. secondly you loose the chance to specify the cardinality, which will lead to a number of problems. I cant find anything suggesting this shortcut in the Guidon how to write a submodel template and also no hint to handle SML in this special way in the metamodel.

In the following I will demonstrate with a few pictures my proposed changes:

  1. renaming the Submodel
  2. renaming all SML containers if their names don't represent the entities they contain.
  3. Changing the way the Entities of SMLs are modeled and documented and therefore giving them an explicit semantic ID, Explanation and Cardinality.

{FCE35F5A-9F78-427E-B5A4-D69B2B3D3405}

{D78858E4-7C3A-48B4-98B7-4AB6EFF2A1CC}

{91D3394C-5AC4-443B-944D-AEDEFCCA67AE}

Of course I wont go through the whole submodel, but the provided pictures should demonstrate the principle.

The digital nameplate, Provisioning of 3D models and the BOM are entrypoint to the AAS and should not require the digging i had to do to undestand what is meant and why there are unnamed entities in the AASX i get provided.

I hope this helps you increase the quality of your informationmodel. Best regards MWLY

Edit: Spelling

Rudra-sandeep commented 3 weeks ago

@mwly Thank you for the suggestions we will forward this issue to the respective working group