adminarchitect / core

AdminArchitect - Active Admin for Laravel
http://adminarchitect.com
MIT License
211 stars 66 forks source link

Datetime type is provided, but yields date #27

Closed dinandmentink closed 6 years ago

dinandmentink commented 6 years ago

When using a datetime input type the Terranet\Administrator\Form\Type\Datetime is correctly selected.

Expected behaviour: this element has a datetime selector (eg bootstrap-datetimepicker) Actual behaviour: this element has a date selector.

If interested I can make a PR against adminarchitect/core and adminarchitect/mix to include a datetimepicker element. But wanted to check if this would be appreciated first.

Reproduce by:

public function form()
    {
        return $this
        ->scaffoldForm()
        ->update('party_at', function($e){ return $e->setInput('datetime'); });
    }
endihunter commented 6 years ago

@dinandmentink it's fixed. Thanks for reporting the issue.

dinandmentink commented 6 years ago

Thank you :+1:

endihunter commented 6 years ago

@dinandmentink to make it working, you need to update adminarchitect/core and install the latest version of @adminarchitect/mix.

dinandmentink commented 6 years ago

Thanks. I'll do so.

Have you seen my PR against /mix? It seems npm doesnt resolve daterangepicker correctly.

dinandmentink commented 6 years ago

Question. the latest version of @adminarchitect/mix isn't updated since october. Has there been a release specific for this issue?

endihunter commented 6 years ago

@dinandmentink it's not updated on github, but npmjs contains the latest version