adminfaces / admin-starter

https://adminfaces.github.io/admin-starter/
48 stars 38 forks source link

Primefaces v11 not working. v10 has broken code #17

Open alin-c opened 2 years ago

alin-c commented 2 years ago

Hi, working on a vanilla clone, I've set Primefaces to v. 11.0.0 and it breaks the app. Moreover, it seems that even v. 10.0.0 isn't working as expected, out-of-the box because apparently the newer versions (after 8) have different requirements for LazyDataModel() - see load() method signature in CarListMB: old (working):

public List<Car> load(int first, int pageSize,
          String sortField, SortOrder sortOrder,
          Map<String, FilterMeta> filters){...}

new (expected):

@Override
public List<Car> load(int first, int pageSize, Map<String, SortMeta> map,
          Map<String, FilterMeta> map1) {...}
rmpestano commented 2 years ago

Hi @alin-c,

Yes I noticed that, just didn't spend the time to fix it.

Thanks for the feedback!