Skins does not change Primefaces components colors.

adminfaces / admin-template

JSF responsive admin template based on Bootstrap and AdminLTE

https://adminfaces.github.io/docs/latest/#admin_template

MIT License

206 stars 101 forks source link

Skins does not change Primefaces components colors. #146

Open mnesarco opened 5 years ago

mnesarco commented 5 years ago

Issue Overview

I have tested all skins: navbar and menu colors are set by the skin, but links, buttons, table headers, panels, etc remain the same: bluesy.

Current Behaviour

Skin does not affect primefaces components colors.

Expected Behaviour

Skins should set colors for everything.

How to reproduce

Additional Information

AdminFaces version: 1.0.0.RC19
PrimeFaces version: 6.2
JSF implementation: 2.3

rmpestano commented 5 years ago

Hi @mnesarco,

sorry for the delayed reply.

For now this behavior is "by design", it is how it works on admin-lte, see here. However this is quite possible to implement but we would need to discuss how every component would work, for example how btn-primary should look like on skin-red? and btn-danger? both would be red?

IN terms of implementation it is quite easy to change the colors of components based on the skin because the skin name is on the body of the page...