search

adminfaces / admin-theme

Primefaces admin theme based on Admin LTE and Bootstrap
https://adminfaces.github.io/site/docs/latest/#admin_theme
MIT License
144 stars 62 forks source link

Upgrade bootstrap 4 #108

Open fif10 opened 6 years ago

fif10 commented 6 years ago

Hello

I just wanted to know if there is any plan to upgrade to bootstrap 4.

Thanks a lot for the great work.

rmpestano commented 6 years ago

Hi there, AdminFaces is based on AdminLTE which is not compatible with BS 4 at moment, follow this issue for more details: https://github.com/almasaeed2010/AdminLTE/issues/710

So unfortunately we'll not be able to upgrade right now but as soon AdminLTE brings BS4 support we can start working on this.

Just out of curiosity, what features of BS4 you're missing the most right now?

fif10 commented 6 years ago

Hi

Thank you for your reply.

Not really missing features, but my concern was mainly to use bs3 features (or custo usage) incompatible with bs4 if you were about to release soon. (was also alot of curiosity :=))

Thanks a lot.

rruffer commented 5 years ago

I understand that the admin-theme is based on admin lite. But I could throw a theme apart with bootstrap 4. just incorporating the same css. without anything from admin lite.

rmpestano commented 5 years ago

Hi @rruffer,

so the without bootstap classifier plus BS4, works for you?

To be honest I've never tried BS4, if replacing BS3 with 4 don't break existing applications then I have no problems in upgrading and would accept PRs.

Thanks for weighing in.

rruffer commented 5 years ago

It is an option. I'll test. But I believe you will not be 100%

dguna commented 3 years ago

Hello, Thanks for the good work. AdminLTE 3 is released and it supports BS4. Will Adminfaces will support BS4?