Fix modal dialogs z-index

adminfaces / admin-theme

Primefaces admin theme based on Admin LTE and Bootstrap

https://adminfaces.github.io/site/docs/latest/#admin_theme

MIT License

145 stars 62 forks source link

Fix modal dialogs z-index #219

Closed lagar84 closed 5 years ago

lagar84 commented 5 years ago

Related to issue https://github.com/adminfaces/admin-template/issues/119 : lower values of bootstrap z-index variables by 100, making primefaces dialog free to use the 1000 values space. Also removes the z-index !important that have been placed in the previous workaround.

More extensive testing welcome.

rmpestano commented 5 years ago

Hi again @lagar84, I've tested your PR and found some issues with "overlay" components inside dialogs such as autocomplete, selectOne, SelectCheckboxmenu and calendar but I think it is easy to fix, see attached images:

screenshot from 2019-01-07 22-14-03

I think removing the z-index from the components should fix the issue.

The source code of the page from the screenshots above can be found here: https://github.com/adminfaces/admin-showcase/blob/9c5e641e0d1a589db9a74938b87fb2f7c196f566/src/main/webapp/pages/components/dialog.xhtml#L171

lagar84 commented 5 years ago

I will take a look

lagar84 commented 5 years ago

Indeed I missed to delete some more z-index declarations from calendar.less and dialog.less - Removing them I cannot reproduce the problem anymore in your dialog.xhtml file.

rmpestano commented 5 years ago

Thank you very much @lagar84!