adminfaces / admin-theme

Primefaces admin theme based on Admin LTE and Bootstrap
https://adminfaces.github.io/site/docs/latest/#admin_theme
MIT License
145 stars 62 forks source link

Fix tooltip z-index #248

Closed gino0631 closed 3 years ago

gino0631 commented 3 years ago
Issue Overview

A p:tooltip is behind pop-up elements.

Current Behaviour

Currently, theme.css sets a fixed value of 932 to a tooltip element:

div.ui-tooltip {
    z-index: 932 !important;
}

As z-index of pop-up elements (p:dialog, p:calendar) is higher than 1000 and is incrementing, this makes p:tooltip invisible (behind the element).

Expected Behaviour

A p:tooltip staying always on top.

How to reproduce

Check the tooltips over Previous and Next buttons of the pop-up calendar:

<p:tooltip/>
<p:calendar ...></p:calendar>

The issue can be fixed by removing z-index declaration from tooltip.less, as it was done in #219 for other components.

Additional Information
rmpestano commented 3 years ago

Thank you @gino0631, I'll starting to work on a new version that targets PrimeFaces 10 so if you find something else, please create issues.

gino0631 commented 3 years ago

Just checked with PrimeFaces 8, and was able to reproduce the problem. The screenshot below shows the overridden z-index value:

image