Closed nspilman closed 3 months ago
Updating shortly - draft
A few things here:
I think we should vertically condense the list items even more. Even just using today as an example, looking at prod there are like 20+ events, it should be much quicker to scroll through all these items. The updates you made definitely move us in the right direction, but should probably condense it even more so. Right now on mobile we can see at max like 4 events at the same time. We can probably increase the overall number while still keeping a lot of the information if we think of a good way to organize it.
Some other misc things:
1) The images aren't always the same size on mobile:
2) The darkened overlay doesn't always overlap properly:
3) The darkened overlays are also making the venue links unclickable. 4) The EventCard also impacts both the map view and the admin view. Probably best to create a new component here for the list view display.
@admiralbolt See the above styling update
Merged master in (hopefully didn't break anything)! Looking much better, a few things:
Will you replace the address with the Venue Name on the right side? and remove the venue name from the image square on the left?
Will you move the start time to be inline with the venue name?
I think the guitar / mic icons look bad overlayed on the thumbnail, so we can probably just remove those as well.
One really weird specific bug => On chrome devtools viewing as a phone if you swap back and forth between the list and map views it resets the filters. Doesn't happen if you're fullscreen, only if you're on mobile view.
@admiralbolt
resolves - https://github.com/admiralbolt/sms/issues/17
it turns out I hadn't already installed Tailwind, so this does that as well. I can break that into its own PR if you'd like.
This PR -
Inspiration - https://www.kexp.org/events/kexp-events/