search

admiraltyio / admiralty

A system of Kubernetes controllers that intelligently schedules workloads across clusters.
https://admiralty.io
Apache License 2.0
673 stars 87 forks source link

feat: configurable arguments for the scheduler plugins #210

Open marwanad opened 3 months ago

marwanad commented 3 months ago

This change adds configurable arguments for both the proxy and candidate plugins and changes the filterWait in the proxy plugin and preBindWait in the candidate plugin to be configurable.

I also updated the scheduler config api version to v1 as part of this change.

adrienjt commented 1 week ago

This is a lot of boilerplate to add plugin config options. Note that the proxy scheduler already sources some of its config from environment variables (CLUSTER_NAME) and from (Cluster)Target CRDs. Also, you may want different wait durations depending on the cluster, or perhaps depending on the pod. Both for simplicity and flexibility, may I suggest two alternatives: