search

admirhusic / GoodFirstIssueFinder

A simple app which helps you find a good first issue
https://good-first-issue-finder.vercel.app
0 stars 4 forks source link

Pagination is in dark mode #11

Closed admirhusic closed 1 week ago

admirhusic commented 2 weeks ago

The pagination seems to be in dark mode, even if we currently do not support dark mode. This should be fixed and the pagination should be white.

Screenshot 2024-07-01 at 23 20 21
satyam1024 commented 2 weeks ago

Hello @admirhusic! Nice to meet you! I’m not sure if I’ll be able to fix it, but I would like to give it a try.

admirhusic commented 2 weeks ago

@satyam1024 The issue is yours! Good luck!

satyam1024 commented 2 weeks ago

I am getting an error 422 when running the app can you help me with this

Screenshot (2845)1

admirhusic commented 2 weeks ago

@satyam1024 have you configured the berear token in the .env file? If not, you have to go to developer settings in your Github account and activate a personal access token. Copy the env.example file a rename it to .env and set the token as the value. Hope this helps.

satyam1024 commented 2 weeks ago

Thank you for your response. It seems that was indeed the issue. The feature is working now, but pagination isn't displaying in dark mode. Are there any specific conditions needed to replicate this problem? Screenshot (2846)

admirhusic commented 2 weeks ago

@satyam1024 at the time of testing, it was night. I assume that tailwind has a way to detect the devices theme and set the background color. Not sure how this works.

satyam1024 commented 2 weeks ago

then should we go ahead and close this issue now? or is there anything i can do.

satyam1024 commented 2 weeks ago

This isn't related to the issue, but I want to thank you. When I first started contributing to open source, it was very overwhelming, and I was about to give up. Then I found your project and it really helped me a lot and I learned many things from it. Thank you

admirhusic commented 2 weeks ago

@satyam1024 You are welcome. I'm happy that this project motivated you. Keep on hacking!

admirhusic commented 2 weeks ago

@satyam1024 Let me know if you are working on this. If not, I will close this issue, since my idea is to implement a infinite scroll in the future, which will provide a better UX than the current implementation, and also the current pagination has some flaws.

satyam1024 commented 2 weeks ago

No, please go ahead and close this issue.