search

admob-plus / admob-plus

Trustable AdMob Plugin for Cordova, Capacitor, Ionic, React Native
https://admob-plus.github.io
MIT License
361 stars 149 forks source link

Integrate cordova plugin into capacitorjs. Need minor code changes #620

Open merbin2012 opened 7 months ago

merbin2012 commented 7 months ago

The capacitor admob plugin doesn't support the app open ad, so I have planned to integrate the Cordova admob plugin into capacitorjs app and successfully integrate and currently all the ads are working properly including the app open ad.

But after fixing the minor issue in the admob.js file, but it is not affected in Cordova but it is affected in capacitorjs.

with "admob-plus-cordova": "^2.0.0-alpha.13" 1) Line number 523 - Open bracket is missing var html = "\n\n ").concat(opts.npa To var html = ("\n\n ").concat(opts.npa 2) Line number 565 - Open bracket is missing html = "\n\n <ins class=\"adsby .... To html = ("\n\n <ins class=\"adsby.....

harryt2 commented 1 month ago

Yep, found this too, missing the first (