adnuguk / adnuguk.github.io

https://www.aberdeendevelopers.co.uk
1 stars 3 forks source link

Add Cookie Disclaimer to the site #2

Closed gep13 closed 10 years ago

gep13 commented 10 years ago

In order to be compliant with European laws, going to need to add a Cookie Disclaimer to the site.

This seems like quite a nice one:

http://sitebeam.net/cookieconsent/

gep13 commented 10 years ago

Woot, this is all set up and running, and according to the report from the Sitebeam website, and according to the report that I ran, I got a value of 8.9. However...

"This site is trying to be compliant with the Cookie Law However even after opting out, some cookies were still set. You should check Cookie Consent is installed correctly."

May have to speak to @hhariri about this one, as I "borrowed" the code from his site :-)

gep13 commented 10 years ago

There is some information about this here:

http://stackoverflow.com/questions/10668292/is-there-a-setting-on-google-analytics-to-suppress-use-of-cookies-for-users-who

gep13 commented 10 years ago

Have a look at the code examples here:

http://sitebeam.net/cookieconsent/documentation/code-examples/

hhariri commented 10 years ago

Interesting. So I set this up using sitebeam.net and now they tell me their own code is invalid? :)

Also, where's the login? Did they completely remove the free option?

hhariri commented 10 years ago

This is so screwed up. I insert their own code and now it fails their own tests (that's after it also tells me it cannot find a web site at that adrress, but then sends in the report.).

Gary, if you find a proper solution, please let me know.

gep13 commented 10 years ago

@hhariri will do. Only started looking at this today, but I will follow up over the weekend. I got logged in with a trial edition, I got an email about setting up the account. Seems it is limited to 10 reports, but that should be more than enough, hopefully.

gep13 commented 10 years ago

Sweet!

image

@hhariri see the changes that I made here https://github.com/adnuguk/adnuguk.github.io/commit/492f0a6da370b5512586e385e295395d1d3ae103#diff-d41d8cd98f00b204e9800998ecf8427e that fixed up the issue I was seeing.

Hope that helps!

hhariri commented 10 years ago

sweet thanks. What about that class in the script? Needs to be defined? and what txt/plain? Ah I see that might be defined by sitebeam

gep13 commented 10 years ago

Yip, my assumption is that the class is defined in here:

https://github.com/adnuguk/adnuguk.github.io/blob/master/_includes/_head.html#L12

or here:

https://github.com/adnuguk/adnuguk.github.io/blob/master/_includes/_head.html#L14

Haven't dug into see exactly what is going on, just wanted to test it to see if it did work :-)

As for txt/plain, not sure why that needed to change, again, not dug into it.

hhariri commented 10 years ago

My site still fails on tests.

gep13 commented 10 years ago

I have had a look at the changes that you made, and they look identical. What exactly is the test failing on? Is there another cookie that is failing the test, or is it the Google Analytics one? I will close this issue for now, but feel free to reply here, or via email.