ado21 / DynamicMacros

Addon designed for WoW
5 stars 2 forks source link

Add manual party update #3

Closed eayates closed 1 year ago

eayates commented 1 year ago

Occasionally the addon will fail to load in the start of the first solo round if queue is joined while in combat. Currently, the addon will not operate at all until the next round. If there was a way to add a command to manually tell the addon to recheck the group (so that you don't have to wait for the actual group update in the next round) or to manually tell the addon to update macros in case the automatic process fails, this would resolve the issue.

ado21 commented 1 year ago

To be honest as I am searching through code I see there is small hiccup which prevents addon to trigger in case you are in combat as you mentioned. Originally it was supposed to block addon from triggering while you are in combat inside of arena, but I guess that is useless prevention which is not needed at all.

Since I am not playing these days I could modify addon and send you fixed version for testing purposes.

eayates commented 1 year ago

I'd be happy to test it! It is an outstanding addition to the game, very excellent addon. I can pull from a development branch or send you my discord.

ado21 commented 1 year ago

if you know how to use branches then greatI ll create new one for this issue and please inform me about results

ado21 commented 1 year ago

Branch name is combat_bug

If this wont help I ll try to implement manual trigger via specific command

eayates commented 1 year ago

The bug was uncommon but I will try hard to recreate and let you know, I have the code from the combat branch now! :D

ado21 commented 1 year ago

Since you did not reply I ll consider this as working