search

adobe-apiplatform / api-gateway-aws

AWS SDK for NGINX with Lua
Apache License 2.0
171 stars 44 forks source link

Fix urlencode #27

Open zrq495 opened 5 years ago

zrq495 commented 5 years ago

When the value has been urlencoded, it needs to be urlencoded again, not just replacing &.

ddragosd commented 5 years ago

Thanks @zrq495 ! Can you also add a test for this case ?

fbergero commented 3 years ago

@zrq495 any updates on this? I need this fix ❤️

zrq495 commented 3 years ago

@ddascal @fbergero I am sorry. I had been trying to run the test, but i failed to make it. I have been using it under my production and it proves to be accessible, so you can use it directly. if it is convenient for you, you can add a test for this case.

fbergero commented 3 years ago

@zrq495 is your build uploaded to luarocks? Additionally this also escapes the topic ARN like

arn%3Aaws%3Asns%3Aus-east-1%3AXXXXXX%3Asometopic

That doesn't make a difference?

zrq495 commented 3 years ago

@fbergero Just build locally I didn't notice ARN, does it not work properly?