multiple changes - Githubissues

adobe-apiplatform / apigateway

A Performant API Gateway based on NGINX and Openresty

MIT License

301 stars 57 forks source link

multiple changes #38

Closed jkt628 closed 7 years ago

jkt628 commented 7 years ago

git submodules
modern alpine and golang
slim container
sync generated subdir only

ddragosd commented 7 years ago

@jkt628 thanks for the submission. The title of this PR states correctly that there are multiple changes 😄 I'm wondering if it would be possible to split this one into smaller ones. Smaller, incremental changes are easier to review and take a shorter time to merge.

I'm thinking we could very quickly expedite the last commit about updating to the latest api-gateway-config-supervisor .
Then we could have another PR for adding submodules to this repo and discuss it separately.
slim container could be another one.
sync'ing subfolders such as generated-conf.d could be another one.

WDYT ?

jkt628 commented 7 years ago

i apologize for the approach here; my intention was to get as quickly as possible to where @MikeWillCook and i are currently running. i did invite debate on this approach via email and thought the response was generally positive. unfortunately, the commits reflect the actual path i created to test the changes to api-gateway-config-supervisor within apigateway. i can undo my work and redo it all again but i would absolutely rue the wasted time. if you want individual PRs reflecting each change i can do that easily but the order will not be as you requested. if this is an impediment to adoption i will start over, let me know.

jkt628 commented 7 years ago

Merge remote-tracking branch 'upstream/master'

rjmarsh commented 7 years ago

Resubmit as individual PRs:

Required

update the config-supervisor
sync generated subdir only
TCP

Optional

git submodules (legal considerations because of libraries)
slim container
modern alpine and golang