search

adobe-apiplatform / mesos-actor

An Akka based Mesos actor for creating Mesos frameworks.
Apache License 2.0
10 stars 8 forks source link

Explicit Decline of offers #19

Closed Himavanth closed 5 years ago

Himavanth commented 6 years ago

As per the documentation of mesos, if some offers are accepted, the others in the same lot should implicitly get declined. But this is not happening in all cases and the offers get blocked as "outstanding offers" as seen in the mesos UI. Expicitly declining them should do no harm afaics

tysonnorris commented 6 years ago

Docs say that "accept" call will implicitly decline unused offer resources - I was under the impression (wrong?) that unaccepted offers will also be implicitly declined during accept processing. Can you verify that offers end up in a bad state in this case?

Himavanth commented 6 years ago

@tysonnorris Yes the docs do say that. In fact i was under the same impression and was puzzled to see outstanding offers in mesos UI while the sampleHAFramework was not getting the offers of unused resources. I don't see the outstanding offers anymore if i decline the offers first and then send the accept.

Though this is consistently reproducible with the sampleHAFramework, i am unsure why we would not see this in any of OW deployments. Do you think there is something else at work here or is it safe to decline first?

outstanding_offers unused_agents

tysonnorris commented 6 years ago

Is this because the sample framework shuts down without a decline? (and in OW maybe it doesn't do that). Also, is there any difference in declining after the accept? (if not, let's do that?) Also, please check that there is handling of all the future completions, this may not be done currently I think @chetanmeh pointed this out. Thanks!

tysonnorris commented 5 years ago

included same functionality in #38