search

adobe-apiplatform / mesos-actor

An Akka based Mesos actor for creating Mesos frameworks.
Apache License 2.0
10 stars 8 forks source link

Switch to Scala 2.12.7 #27

Closed chetanmeh closed 5 years ago

chetanmeh commented 5 years ago

Fixes #26

codecov-io commented 5 years ago

Codecov Report

Merging #27 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files           6        6           
  Lines         104      104           
  Branches       12       12           
=======================================
  Hits           97       97           
  Misses          7        7
Impacted Files Coverage Δ
...adobe/api/platform/runtime/mesos/MesosClient.scala 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51f707d...9134c06. Read the comment docs.

chetanmeh commented 5 years ago

@tysonnorris Gradle does not seem to provide a simple way to generate cross builds

I was thinking to make a release with version 0.0.8_2.12 from this branch to see how far we can move in OpenWhisk core repo. Later once we have OpenWhisk core moved to 2.12 we can merge this and then do a proper release 0.0.9 and move OpenWhisk core to that version .

Thoughts?

tysonnorris commented 5 years ago

Let's first see if there is a way to parameterize the scala version; otherwise yes it seems fine to create a release from this branch

tysonnorris commented 5 years ago

Can we close this PR in the meantime?

chetanmeh commented 5 years ago

Closing for now. Would reopen once we are ready to merge to master