search

adobe-apiplatform / mesos-actor

An Akka based Mesos actor for creating Mesos frameworks.
Apache License 2.0
10 stars 8 forks source link

forcePull in TaskDef not used when creating tasks #51

Closed alvarolopez closed 3 years ago

alvarolopez commented 5 years ago

Hi.

I am not a Scala programmer, so I might be wrong. It seems that the forcePull paramter, although defined in the TaskDef is never passed to Mesos.

The forcePull parameter is defined here: https://github.com/adobe-apiplatform/mesos-actor/blob/master/src/main/scala/com/adobe/api/platform/runtime/mesos/MesosClient.scala#L108 but it is not being used here: https://github.com/adobe-apiplatform/mesos-actor/blob/master/src/main/scala/com/adobe/api/platform/runtime/mesos/TaskBuilder.scala#L63

tysonnorris commented 5 years ago

I think you are right; Will get it fixed.