search

adobe-apiplatform / mesos-actor

An Akka based Mesos actor for creating Mesos frameworks.
Apache License 2.0
10 stars 8 forks source link

allow matching of offers with exact size as task requirements #56

Closed tysonnorris closed 4 years ago

tysonnorris commented 4 years ago

missed edge case of exact match

codecov-io commented 4 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files           6        6           
  Lines         640      640           
  Branches       44       44           
=======================================
  Hits          365      365           
  Misses        275      275
Impacted Files Coverage Δ
...adobe/api/platform/runtime/mesos/TaskMatcher.scala 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 34cfc1a...4477095. Read the comment docs.

mcdan commented 4 years ago

Love the massive json file to confirm addition of equal sign. :-)

tysonnorris commented 4 years ago

😄 yeah the tests currently validate all the numbers, and I added a test to exercise a different set of numbers, so I made a separate json file with the different numbers.... Its ugly, but the test code is much simpler for it, I think