update connector-umapi.py

adobe-apiplatform / user-sync.py

Application for synchronizing Adobe customer directories via the User Management API

https://adobe-apiplatform.github.io/user-sync.py/en/user-manual/

MIT License

87 stars 67 forks source link

update connector-umapi.py #814

Closed Luci2015 closed 11 months ago

Luci2015 commented 1 year ago

Summary

Testing Steps

use additional_groups with groups auto-create: True
get a 504 on first call that gets all groups from admin console
continue with the sync and see the sending sync start signal before initial GET groups page 0 call

fixes #813

adorton-adobe commented 11 months ago

I understand setting the signal when getting groups (good catch). But I don't understand why the after-mapping hook stuff is moved. Doesn't seem related to the signal change.

Luci2015 commented 11 months ago

It's not related. The after-mapping hook part is a fix for issue #818 Commits were made several months ago and I updated my fork recently to catch up with your latest changes.

adorton-adobe commented 11 months ago

In that case, will you please open a new PR from a branch with the relevant changes isolated? I can't merge this PR since it's coming from a branch that has unrelated changes.