Closed Luci2015 closed 11 months ago
I understand setting the signal when getting groups (good catch). But I don't understand why the after-mapping hook stuff is moved. Doesn't seem related to the signal change.
It's not related. The after-mapping hook part is a fix for issue #818 Commits were made several months ago and I updated my fork recently to catch up with your latest changes.
In that case, will you please open a new PR from a branch with the relevant changes isolated? I can't merge this PR since it's coming from a branch that has unrelated changes.
Summary
Testing Steps
sending sync start signal
before initial GET groups page 0 callfixes #813