adobe-fonts / source-code-pro

Monospaced font family for user interface and coding environments
https://adobe-fonts.github.io/source-code-pro/
SIL Open Font License 1.1
19.85k stars 1.62k forks source link

Some block characters not 100% width #242

Closed lighth7015 closed 4 years ago

lighth7015 commented 4 years ago

On linux, when using TUI applications, Source Code Pro has some SLIGHT space between the box shadow glyphs. image

frankrolf commented 4 years ago

That’s an odd one – I’d be surprised if Quit uses a different box than the shade (and FWIW, the shade of the window itself). Is if possible for you to paste what we’re seeing as characters here?

lighth7015 commented 4 years ago

The author of the library gave me an example to paste in my terminal, and I can confirm the issue is with the glyph itself, though here is the character it is writing to the terminal-

echo -e "\u2580\u2580\u2580"
lighth7015 commented 4 years ago

Here is a Konsole screenshot, with the line hilghighted, so the edges of the character can be seen. image

frankrolf commented 4 years ago

As far as I can see, the glyph itself is 600 units (a.k.a. 100%) wide in all the instances. See for example here: https://github.com/adobe-fonts/source-code-pro/blob/master/Roman/Instances/Regular/font.ufo/glyphs/uphalfblock.glif

This is an issue that has to do with the rasterizer used. Have you tried to see what happens if you are using the alternate outline format? (TTF if you’re currently using OTF, and vice-versa).

lighth7015 commented 4 years ago

Installing the ttf versions of the fonts, and will reply in a few minutes! :D

lighth7015 commented 4 years ago

Yeah, apologies. Konsole is having issues with Source Code Pro, it seems!

frankrolf commented 4 years ago

That’s too bad! What happened when using the TTFs? Also, which fonts work well for you?

lighth7015 commented 4 years ago

The TrueType variants also exhibit the 1px space to the right of the block glyphs. I mean I love Source Sans and Source Code, they're amazing fonts! But I'm just trying to track down where this is coming from so it can get fixed. :D

lighth7015 commented 4 years ago

I figured it out; somehow KDE's anti-aliasing is adding that spacing between the characters. :D

lighth7015 commented 4 years ago

Specifically, "Font smoothing" was the culprit. :D

lighth7015 commented 4 years ago

Yeah, it's been a little over a week and I'm not seeing that issue anymore with my workaround. So I feel safe closing this. Thanks so much for the assistance figuring out what's going on! :D