adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.02k stars 643 forks source link

Incorrect mappings of 5 全-composed characters for HK and TW #109

Closed tamcy closed 10 months ago

tamcy commented 2 years ago

As title. For TW and HK, the upper part of the 全 component should be a 入, not 人. They are not unifiable. Five codepoints are affected:

cyun

# Codepoint Current glyph Remap suggestion
1 U+5168 全 uni5168-JP -> uni5168uE0101-JP
2 U+6D24 洤 uni6D24-CN -> uni6D24-JP
3 U+8DE7 跧 uni8DE7-CN -> uni8DE7-JP
4 U+8F07 輇 uni8F07-CN -> uni8F07-JP
5 U+9293 銓 uni9293-CN -> uni9293-JP

I am aware that the font is using two slightly different designs for JP/KR and TW/HK, like below:

cyun2

The only difference is the length of the horizontal line of 入 (TW/HK is slightly shorter). This, to me, is actually a unifiable difference. Which is why I am not suggesting new glyphs be added.

Marcus98T commented 2 years ago

Well as of 2.001, I have verified the fix, except for 牷 and maybe some others. I suppose in the next version, I suggest mapping those characters to JP/KR forms if all components are unifiable, that is.

UPDATE: Here is a list of characters to review:

佺㓌姾恮拴洤栓烇牷㻇䀬硂絟𧊲詮诠跧輇辁酫銓铨駩𠓾峑𣁦荃筌痊

Screenshot 2022-01-26 at 19 15 36

Green - The JP/KR glyphs to map to HK/TW. (佺拴洤栓牷) Blue - The HK/TW glyphs to be replaced by JP/KR glyphs. (佺拴洤栓牷) Orange - Adjust the 入 component to follow the JP aesthetic of a longer horizontal line. (姾恮烇㻇硂絟𧊲詮駩𠓾峑𣁦荃筌痊) Purple - The HK/TW glyphs to map to JP/KR, after adjustment. (恮㻇硂絟峑) White - No change needed.

punchcutter commented 10 months ago

This original issue was addressed a long time ago so closing this. The additional comments after that can be looked at as part of a new issue if necessary.

Marcus98T commented 10 months ago

The additional comments after that can be looked at as part of a new issue if necessary.

@punchcutter Which is exactly why I already made a new issue regarding the additional 全 mappings. This can be seen as a continuation of this closed issue.