search

adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.02k stars 643 forks source link

Incorrect mappings of characters composed with ⿱攵 characters for HK and TW #115

Closed tamcy closed 2 years ago

tamcy commented 2 years ago

HK and TW treat ⿱攵 and ⿱夂 differently. The following characters are be composed with ⿱攵, thus the mappings are incorrect:

ok

Six codepoints are affected, which can be fixed by changing the mapping to JP:

  1. U+4FEE 修
  2. U+5135 儵
  3. U+52D9 務
  4. U+9380 鎀
  5. U+9797 鞗
  6. U+9BC8 鯈
tamcy commented 2 years ago

So far, the issues I reported have one common pattern - the glyph should be mapped to JP, but was wrongly mapped to CN. No problem with glyphs not mapped to JP. I also just found characters with other components, like 非, 嚴, 咼, 角, 尋, 帚, 犮, 呈, 巨, 呂, 咎 etc., also exhibit this behavior. This makes be wonder, is this not an isolated problem, such that this can be resolved by the same fix? If yes, isn't it better for me to refrain from reporting this kind of issues, and wait for a new version first?

punchcutter commented 2 years ago

From looking at the code points you've listed so far I think I see the main issue where those aren't getting mapped correctly. Waiting for a new version is probably better for these particular mapping issues. I'm more worried about 1.001 fixes being reverted because that shouldn't have happened.

tamcy commented 2 years ago

116 is the issue which fixes in v1.001 got reverted, but the two affected glyphs (uniFF0C-TW and uniFF1B-CN) aren't CJK characters. So far I see no CJK glyph having similar issue.

tamcy commented 2 years ago

Issues about HK/TW codepoints with ⿱攵, 非, 嚴, 咼, 角, 尋, 帚, 犮, 呈, 巨, 呂, 咎 components that were incorrectly mapped are confirmed to be fixed in v2.001. Thanks!