search

adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.16k stars 644 forks source link

Map U+752D 甭 to HK form for JP/KR #159

Closed Marcus98T closed 1 year ago

Marcus98T commented 2 years ago

UPDATE: Please see bottom post and disregard this main post.

Screenshot 2022-03-24 at 00 50 01

Ignore the PingFang reference for SC, TC and HK because I was trying to check if all regions are correct.

This is the Unicode reference, so basically as what the title says. I know it's a K2 source ideograph which is off scope, but granted there's a new HK glyph which follows the K2 reference, and JP/KR Sans already mapped to the HK form, so might as well map to it.

Screenshot 2022-03-24 at 00 46 55

However, it is also possible that the Unicode reference may be wrong and that JP/KR should use the CN form for Sans. That might need further checking on someone else's end, but for now please make the glyph for U+752D consistent for JP/KR between Sans and Serif.

Marcus98T commented 1 year ago

I have to apologize, I have to change the issue slightly.

I did not know until now there was a JP glyph in v1 which actually suited HK. Why did Adobe reinvent the wheel? They should not have removed the v1 JP glyph. Now I suggest that Adobe replace the HK glyph with the v1 JP glyph, please. I have changed the title to reflect that.

I know they already changed the mapping in the source via the "fixed-for-next-release" label on 11 July 2022, but this time, I want the HK glyph replaced with the v1 JP glyph.

The v1 JP glyph can be used for JP, KR and HK.

UPDATE: Here are the glyph difference between v1 JP and HK.

Screenshot 2023-05-25 at 19 17 45


Blue - v1 JP
Red - v2 HK

甭 diff
Marcus98T commented 1 year ago

Fix verified in Noto Serif v2.002. JP and KR are using the HK glyph.

Screenshot 2023-08-17 at 20 14 14

UPDATE: I have verified the fix on the main font.

Screenshot 2023-08-18 at 18 28 52

Because I think this issue originally pertains to remapping, and only because recently I found out there were more v1 JP glyphs that could have been used for HK, the latter request got ignored because it was too late into the font development cycle, and what I said was simply irrelevant. I have closed this issue, reverted the title to its original state, and will open a separate issue later regarding such design discrepancies.

Ultimately, Adobe is simply not obligated to make the font perfect.