search

adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.17k stars 644 forks source link

Nominal form of U+1178 ᅸ, nominal form & vjmo01 glyph of U+D7B5 ힵ #25

Closed acuteaccent closed 7 years ago

acuteaccent commented 7 years ago
  1. The nominal form of U+1178 ᅸ is wrong. U+1178 is ㅑ + ㅗ, not ㅑ + ㅛ (ㅑ + ㅛ is U+1179 ᅹ).
  2. The nominal form and the vjmo01 glyph of U+D7B5 ힵ are wrong. U+D7B5 is ㅜ + ㅕ, not ㅗ + ㅕ (ㅗ +ㅕ is U+D7B0 ힰ).
kenlunde commented 7 years ago

Thank you. The following three glyphs need adjustment: uni1178, uniD7B5, and uniD7B5.vjmo01.

kenlunde commented 7 years ago

I received the fixed glyphs from Sandoll's designer, which are shown below in the ExtraLight, Medium, and Heavy weights. The mappings from the backend CIDs to the glyph names are below:

CID+121 = uni1178 CID+446 = uniD7B5 CID+12563 = uniD7B5.vjmo01

shserif-issue-25-fix

Note that uniD7B5.vjmo01 is shown before it is shifted to the left and its horizontal advance is zeroed out (this is to be able to see the fix more clearly, because it would otherwise display over the glyph for uniD7B5).

acuteaccent commented 7 years ago

Awesome.

acuteaccent commented 7 years ago

BTW, I checked all the glyphs of conjoining hangul jamo (nominal forms, ljmo0[1-6], vjmo0[1-2], and tjmo0[1-4]; haven't checked the high-frequency 500 archaic hangul syllables) in Source Han Serif. I found no other errors besides the ones I have reported so far.

kenlunde commented 7 years ago

Thank you for the positive report. Also, thank you for checking these glyphs and reporting the issues that resulted in 22 glyph corrections. The fixes will be reflected in the first dot-release.

kenlunde commented 7 years ago

Consolidated with Issue #39.