adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.17k stars 644 forks source link

Enhancement: Incorrect Fallback Glyph for U+6902 (椂) on TW #32

Closed hfhchan closed 7 years ago

hfhchan commented 7 years ago

The fallback glyph for U+6902 (椂) on TW is currently CID 21954 which follows the CN conventions instead of the TW conventions.

image

A better fallback glyph already exists as 21953, which is more suitable for TW than 21954.

hfhchan commented 7 years ago

The fallback glyph for U+6903 (椃) on TW is currently CID 29156 which follows the CN conventions instead of the TW conventions.

image

A better fallback glyph already exists as 21956, which is more suitable for TW than 21955.

kenlunde commented 7 years ago

Note that U+6902 椂 and U+6903 椃 will get an appropriate form when HK support is added in Version 2.000, thus the as designed label, but I did set a note to map these characters to the JP glyphs as a temporary measure.

hfhchan commented 7 years ago

Hmm... U+4FFF 俿, U+458E 䖎 and U+4593 䖓 already bear similar treatment where the TW glyph is blank in the region-specific subsets and fallback from JP in the language-specific otfs.

I also found U+9BF1 鯱, U+88ED 裭, U+5A4B 婋, which could bear the same treatment.

hfhchan commented 7 years ago

The "incorrect" fallback to CN glyph also occurs for U+6947 楇 and U+7171 煱. Interestingly, the fallback TW glyph for U+5368 卨 is already overridden to that of JP.

kenlunde commented 7 years ago

The moment one goes beyond the scope of Big Five, the chances of encountering such fallback is relatively high. U+458E 䖎, U+4593 䖓, U+4FFF 俿, and U+5368 卨 are simply carry-overs from mapping overrides that were used in Source Han Sans.

Also, the left-side component of U+88ED 裭 and U+5A4B 婋 makes me want to leave them as-is.

kenlunde commented 7 years ago

Consolidated with Issue #37.