Unused subroutines in CFF, again

adobe-fonts / source-han-serif

https://adobe.ly/SourceHanSerif

Other

8.17k stars 644 forks source link

Unused subroutines in CFF, again #35

Closed mashabow closed 7 years ago

mashabow commented 7 years ago

In spite of the new subroutinizer, Source Han Serif also has some unused subroutines. The same issue as https://github.com/adobe-fonts/source-han-sans/issues/162.

grep result

``` $ ttx --version 3.9.2 $ ttx -t CFF -o cff.ttx SourceHanSerifJP-Regular.otf Dumping "SourceHanSerifJP-Regular.otf" to "cff.ttx"... Dumping 'CFF ' table... $ grep -e FontName -e raw cff.ttx ```

kenlunde commented 7 years ago

Thank you for checking.

This has been reported to the appropriate engineer. Because this is a tool issue, and likely a harmless one, I am closing this, marking it with enhancement, not this product, and to track.

You might consider posting this as a new AFDKO issue, being sure to reference this issue and the Source Han Sans one.

kenlunde commented 7 years ago

According to the engineer, in addition to the presence of unreferenced subroutines, which is the result of the subroutinizer running in two phases, there is also the possibility of some subroutines being referenced only once.

twardoch commented 7 years ago

@kenlunde "subroutines being referenced only once" means that these portions could be placed verbatim into the regular Charstring's glyph definitions, i.e. there is no benefit of placing them as subroutines, but there is no harm in doing so either — right?

kenlunde commented 7 years ago

Correct. We're already testing a new version that does this.