adobe-fonts / source-han-serif

Source Han Serif | 思源宋体 | 思源宋體 | 思源宋體 香港 | 源ノ明朝 | 본명조
https://adobe.ly/SourceHanSerif
Other
8.12k stars 645 forks source link

Incorrect width for character 关 on Serif K #5

Closed PhantomThief closed 7 years ago

PhantomThief commented 7 years ago

compare to Source Han Sans the character 关 has larger width on Source Han Sans K to Source Han Sans while, it has wrong width for Serif K comparing to Serif.

screen shot 2017-04-04 at 4 53 56 pm
jimmymasaru commented 7 years ago

+1 for this issue because:

  1. 关 and 复 are not used in South Korea so that it doesn't matter which one is used.
  2. It can benefit those Chinese users who also prefer Kangxi Style glyphs because Korean variant is the closest one to Kangxi Style. It could make glyphs more consistent (at least widthwise) since these characters are quite commonly used.
kenlunde commented 7 years ago

@jimmymasaru is correct that U+5173 关 doesn't correspond to either KS standard, so while I consider this a bug, it is not considered urgent. We did override its glyph for the KR fonts of Source Han Sans to use the CN glyph, uni5173-CN, and that override fell between the proverbial cracks. I made a note to add the override for the first update. It is a simple fix, but because it is not urgent for reasons already explained, it will not trigger an update.

Thank you for noticing and reporting this.

KrasnayaPloshchad commented 7 years ago

The following material can be seen as model: http://old.pep.com.cn/lsysh/jszx/tbjxzy/tpsc/photo/f/201008/t20100827_800362.htm

kenlunde commented 7 years ago

Consolidated with Issue #37.

KrasnayaPloshchad commented 7 years ago

The following material can be seen as model: http://old.pep.com.cn/lsysh/jszx/tbjxzy/tpsc/photo/f/201008/t20100827_800362.htm

Also see: https://tinyurl.com/k2hzug8

kenlunde commented 7 years ago

The situation for U+5173 关 is no different than Source Han Sans. I simply forgot to override the mapping for the KR CMap resource like I did for that typeface. The JP form is unique in that it is thinner. The form used by CN and TW should not be thin, and although this character is outside the scope of the KR support, meaning not in KS X 1001 or KS X 1002, it is an easy fix.