Open tamcy opened 10 months ago
Thank you for the note! Thank you also for confirming that the released fonts are OK – the contour reversal is something that checkoutlinesufo
should take care of (but of course it’s good practice to have the contour order be correct in the source UFOs also).
I was curious if there were any other inadvertently-clockwise glyphs, and came up with the simplest possible script:
f = CurrentFont()
for g in f:
if g.contours:
x1, y1, x2, y2 = g.bounds
ng = g.copy()
p = ng.getPen()
p.moveTo((x1, y1))
p.lineTo((x2, y1))
p.lineTo((x2, y2))
p.lineTo((x1, y2))
p.closePath()
ng.removeOverlap()
if len(ng.contours[0].points) > 4:
print(g.name)
Fortunately, no result (after fixing that theta)
Two similarily looking glyphs,
theta
andfita
, are created with a different contour order:This results different contour order when converting the master .ufo to .pfa with the
tx
command:Take this command for instance:
Here's the result (Left:![image](https://github.com/adobe-fonts/source-serif/assets/959433/b17f003f-e19e-4934-9afb-264c1a52f604)
theta
, Right:fita
):If a font is produced with this source,
fita
will render correctly, buttheta
could be incorrect at certain size, probably depending on the rendering engine:Note that fonts released here seems fine. The problem arises when a custom build from the masters is needed.
I checked several glyphs that are similar in composition (
Oslash
,oslash
,theta
,Fita
,fita
,Obarcyr
,obarcyr
,Fita.sc
,Obarcyr.sc
), withtheta
's contour direction being the only exception, thus I tend to think this is something to do with the source, not thetx
script, so I am reporting it here. Thanks in advance!