adobe-fonts / source-serif

Typeface for setting text in many sizes, weights, and languages. Designed to complement Source Sans.
https://adobe-fonts.github.io/source-serif
SIL Open Font License 1.1
2.17k stars 163 forks source link

Diacritical dot support for Italics #61

Closed JNord03 closed 5 years ago

JNord03 commented 5 years ago

Hey guys, I'd love to see the implementation of glyphs containing the diacritical dots also for the Italics of SSP. Is there any chance of doing that? I don't think it should be too complicated as the base glyphs already exist. Especially the ḥ glyph is of vital importance to me. It's such a pity that this amazing typeface cannot be used in works containing DMG transcriptions for that reason. Regards,

BTW, the italics done so far look excellent!

frankrolf commented 5 years ago

The “diacritic point” – which exact sequence of code points are you thinking about? There’s a large chance the font already supports it – if there is a discrepancy between Roman and Italics it is no longer deliberate (as of release 3.000, issued last week): https://github.com/adobe-fonts/source-serif-pro/releases/tag/3.000R

JNord03 commented 5 years ago

I've just realised that in English, it's called a diacritical dot, not a point (Ja, das Deutsche kann manchmal ziemlich verwirrend sein). Anyway, it's not included in ISO 8859, so I doubted it was already done. These signs only exist in Unicode, I think. However, they actually are included in the updated Italics. That's wonderful, huge thanks to you.

frankrolf commented 5 years ago

I assume this was about the Umlaut, two consecutive dots also known as diaeresis or trema. Yes, U+0308 COMBINING DIAERESIS is supported across all the styles, and is wired up in the mark feature. I think it should be available in older font versions as well.

JNord03 commented 5 years ago

I was referring to this single diacritic element (◌̇ or ◌̣), not the trema (¨).

frankrolf commented 5 years ago

Sorry for misunderstanding – it is easier to mention the code point right from the beginning. I am trying to reproduce the error in different text engines, but don’t encounter a problem.

I am using the following combinations: h + U+0307 COMBINING DOT ABOVE h + U+0323 COMBINING DOT BELOW

CoreText (Apple Safari)

Screen Shot 2019-06-19 at 16 09 23

FreeType (Google Chrome)

Screen Shot 2019-06-19 at 16 07 22

All possible combinations involving the COMBINING DOTs as rendered in Adobe InDesign 2019-06-19_161608

(see also 2019-06-19_160747.pdf )

In short, I cannot reproduce the issue using the tools at my disposal.

HOWEVER: I just installed LibreOffice for Mac – it seems that an older version of Source Serif is bundled with the application. Since U+1E25 LATIN SMALL LETTER H WITH DOT BELOW is part of Adobe Latin-4 (which is the new Latin character set since the 3.0 update), it is possible that that mark-to-base combination does not exist in a previous version of Source Serif either.

Unfortunately, this list does not mention the version number: https://wiki.documentfoundation.org/Fonts

Please let me know if you find out how to deactivate bundled fonts in LibreOffice, and if you manage to use Source Serif 3.0 in it.

UPDATE: The bundled version of Source Serif Italic is 1.007. I assume that removing the font from the application package (macOS) or /opt/ (Linux) would work: https://ask.libreoffice.org/en/question/191552/how-to-remove-noto-fonts/

JNord03 commented 5 years ago

Well, it seems that when running Windows, the only current solution is installing the font after LibreOffice and every upcoming update up until the inclusion of Source Serif Pro 3.0.

With the overwritten font, however, I get a very weird rendering with OpenGL turned off (as my laptop's video card seems to be on the OpenGL "blacklist"). This for good reason: the letters appear really unclean when I override this blacklisting through the options. a b On the other hand, with it turned off, the rendering becomes a true eyesore when zoomed out. c Zoomed in, as opposed to before, it all looks fine. d I prefer the solution with OpenGL despite the ruggedness, but only as a compromise solution. The older font version included in LO, though, works fine when rendered without OpenGL.

The good thing is that, apparently, the LO-bundled fonts are installed to the default Windows location so that they can still be removed or modified.

What are your thougts on this rendering bug?

frankrolf commented 5 years ago

I suggest opening a new issue for this rendering problem – however I assume there’s not much I can do on my end. When you open the new bug, please specify which outline version you use (OTF or TTF).

FYI: To make the images show up in-line, I inserted them via drag-and-drop.

JNord03 commented 5 years ago

Done. Thanks again for your effort.

fitojb commented 5 years ago

For the record, LibreOffice is now updated to bundle version 3 of the Source Serif fonts.

frankrolf commented 5 years ago

Great news @fitojb! Thank you!

JNord03 commented 5 years ago

They were actually faster than what I'd expected. I mean, they gotta have a lot of bundled fonts to check for updates.