search

adobe-fonts / source-serif

Typeface for setting text in many sizes, weights, and languages. Designed to complement Source Sans.
https://adobe-fonts.github.io/source-serif
SIL Open Font License 1.1
2.17k stars 163 forks source link

Add support for combining double marks #66

Open KrasnayaPloshchad opened 5 years ago

KrasnayaPloshchad commented 5 years ago

I found a photo taken from a Taiwanese Bible printed in Pe̍h-ōe-jī, on this image, I saw some texts has some marks over the ng diagraph, but they are placed between two letters. https://commons.wikimedia.org/wiki/File:Taiwanese_Bible_Chim-gian_1933.jpg For example: 24:26 En͞g ha̍p-gi ê ōe ín-tap ê, Chhin-chhiūⁿ ēng chhùi kā lâng chim. 24:27 Lí tio̍h tāi-seng pi-pān gōa-thâu ê sū, Chhân-hn᷍g liāu-lí chheng-chhó, chiah thang khí-chhù. 26:8 Chhin-chhiūⁿ ēng chi̍t pò͘-tē-á pó-chio̍h khn​̀g ti chio̍h-tūi ê lāi-bīn. (The above texts were typed with characters picked with BabelMap, I’m not clear what the contents are, but seen from the word chim-giân, I guess it should be the Proverbs of the Old Testament)

To make them properly rendered with Source Serif Pro, you need to add support for combining double marks such as U+035E and U+1DCD.

frankrolf commented 5 years ago

Thanks for the report! I have implemented double-width marks before, and I’d be curious to see if the text renders as you expect it to when using Minion 3.

frankrolf commented 3 years ago

@KrasnayaPloshchad Did you get a chance to test this with Minion 3? Do you need any assistance?

KrasnayaPloshchad commented 3 years ago

OK, I tested with Minion 3, but I saw three missings in there:

  1. U+1DCD is missing. 图片
  2. U+030D is above the tittle, which shouldn’t be, the U+0358 should placed near to the right side of character frame, but not overlap the macron. 图片
frankrolf commented 3 years ago

Thanks!