search

adobe-fonts / source-serif

Typeface for setting text in many sizes, weights, and languages. Designed to complement Source Sans.
https://adobe-fonts.github.io/source-serif
SIL Open Font License 1.1
2.17k stars 163 forks source link

Letters i and j with diacritics, and Soft_Dotted property #71

Closed codepointless closed 3 years ago

codepointless commented 4 years ago

Latin letters i and j should lose their dot when used with any combining marks above. It is pointed out in the Unicode standard (see section ‘Diacritics on i and j’ on page 289 and figure 7-2), and popular fonts follow this practice: Times With Source Serif Pro, I get this instead: Source Serif

Actually, the same rule also applies to Latin characters į ị ⁱ ʲ and Cyrillic letters і ј, since they all have the Soft_Dotted property in Unicode (see PropList.txt; here I list only characters included in Source Serif). Unfortunately, existing fonts support this property very inconsistently, and Noto seems to be the only font that really tries to do it right.

frankrolf commented 4 years ago

Which environment do you observe this behavior in?

codepointless commented 4 years ago

I tried MS Word, and also made HTML and opened it in Firefox. In both cases diacritical marks are rendered correctly only if a precomposed character exists in the font. So, j with combining circumflex looks like ĵ, but j with combining acute looks like... well, see the picture above.

Oh, I also tried web-fonts here. Same result anyway.

frankrolf commented 4 years ago

This is a good time to bring this up – thank you for that. I will have a look at the feature code, and hopefully fix the problem.

frankrolf commented 4 years ago

I fixed the issue for i j і ј (Latin and Cyrillic), as well as į ị. There currently is no method in place for combining accents on top of superiors, so I left out ⁱ ʲ.

frankrolf commented 3 years ago

This is resolved in Source Serif 4.004: https://github.com/adobe-fonts/source-serif/releases/tag/4.004R