search

adobe-photoshop / generator-assets

Generator Plug-in for Adobe Photoshop CC that helps users export image assets
MIT License
496 stars 86 forks source link

generator.js file stops working, how to set defaults? #373

Closed thinkMichel closed 8 years ago

thinkMichel commented 9 years ago

Searching the issue list it seems like the only option to change some default settings (specifically the interpolation) is now broken in 2015? Is there any way to set the interpolation again?

The automatic interpolation makes a mess of 'hard edges' when scaling down to 33.33%. My only alternative would be to manually scale the document to each file size. and then copy/paste the generated files.. I was hoping to use the default layer to automatically generate drawable-mdpi, hdpi, xhdpi etc folders based on a single file..

joelrbrandt commented 9 years ago

@isonno could you please give @thinkMichel a status update on the generator configuration file woes? I think it's the case that manually created config files work? And I think its the case that the overall problem associated with using the panel to create configs will be fixed in the next release? But, I can't seem to find certain confirmation of that.

chrisbank commented 9 years ago

Do you know that the interpolation is automatic? From the code it looks like the config files still work and by default the interpolation is undefined so it will just use the setting in the PSD

thinkMichel commented 9 years ago

Hi guys, thanks for all the replies. What i know is: if i use the plugin ui that generates a generator.js file (with formatting => module.exports etc) no new images are generated. I tried rebooting photoshop, also tried to replace the generator.js with a generator.json with the json markup as specified in the wiki, again with interpolation set to a specific value. This also seems to break the image generator as again no images are created.

Perhaps my config file is wrong? If anyone has a confirmed working config file, i would love to test that.

I am not sure if the default interpolation is automatic, but i recall to have read something along those lines in the documentation.

If it takes the setting in photoshop, which setting would that be? the one on Image-> Image Size?

Below is a test i did, the Image Size was set to nearest neighbor. On the left the image generated by image generator. On the right the image that was manually resized (using nearest neighbor). As you can see they are quite different when zoomed in.

test_gernerator

isonno commented 8 years ago

Watson claims this is fixed: https://watsonexp.corp.adobe.com/#bug=4010097

chadrolfs commented 8 years ago

Yes, this looks to be working correctly now in the most current release. @thinkMichel please re-open with comments if you are still seeing this.