Layer comps scaled with ?x200: output may be off by one pixel

adobe-photoshop / generator-assets

Generator Plug-in for Adobe Photoshop CC that helps users export image assets

MIT License

496 stars 86 forks source link

Layer comps scaled with ?x200: output may be off by one pixel #394

Closed mcilroyc closed 8 years ago

mcilroyc commented 8 years ago

The layer-comps automation test is passing, but one small issue is hidden within. As originally reported as a side-note to #387, in this case the output is 200x199. This may have to do with layer effects, as it is not reproducible with an extremely simple case.

pineapplespatula commented 8 years ago

This is likely related to our not handling layer effects correctly in our own bounds model. (which is part of why i think we should let PS tell us exact bounds more often)

pineapplespatula commented 8 years ago

@chadrolfs can you repro this. I think it is fixed in the latest build

chadrolfs commented 8 years ago

Using the layer-comps.psd g-a-a test file, this looks fixed with the latest builds. 🎉