search

adobe-photoshop / generator-core

Core Node.js library for Adobe Photoshop CC's Generator extensibility layer
MIT License
692 stars 97 forks source link

Fix: Guides coordinate unit must be pixel #366

Closed ghenania closed 8 years ago

ghenania commented 8 years ago

getGuides() must return guides with pixel as coordinate unit but the code for that doesn't work.

Jolg42 commented 8 years ago

Hi @mcilroyc,

Is it possible to merge it?

mcilroyc commented 8 years ago

@ghenania thanks for the PR. Can you expand on why "getGuides() must return guides with pixel as coordinate unit"?

Anyway, I think this change is in line with the original intention of the code, it was just not implemented correctly.

Please take a moment to sign our contributor agreement so that I can merge your PR. https://secure.echosign.com/public/hostedForm?formid=8IWLQL2I3V7F6R

ghenania commented 8 years ago

@mcilroyc Just because, as you noticed, it is in line with the original intention of the code.