search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Pressing cmd+n too early causes errors #1670

Open baaygun opened 9 years ago

baaygun commented 9 years ago

Solution might be to turn off menu commands during initialization, but all our initial getters fail if the user presses cmd+n too early on startup and the modal New... dialog pops up.

iwehrman commented 9 years ago

Hmmm, I thought we already did that...

baaygun commented 9 years ago

The fix will be in the core side, and they will need to prevent menu shortcuts from firing if PS launches with Design Space. Chad, can you file a Watson bug?

chadrolfs commented 9 years ago

https://watsonexp.corp.adobe.com//#bug=4019699

tiburbage commented 9 years ago

The fix that Barkin attempted has negative consequences. If you hit Cmd+N too early, the New dialog comes up before DS has fully initialized, and it never works correctly after. Usually the UI fails to draw, but even if it does, event handling is messed up. @jsbache believes this is a problem that has to be solved on the DS side. Please discuss.

iwehrman commented 9 years ago

I've done everything I know of on the JS side to address this, but it isn't enough. We don't have an API to dismiss modal dialogs, only modal tool states, and we're using that very early in our startup routine. I think the plugin either needs to dismiss dialogs with the existing API or provide a new API for us to do so. Back to @tiburbage and/or @jsbache to decide how to proceed.

iwehrman commented 9 years ago

The above comment still holds, but @jsbache and I agreed to defer this until after M3 because the likelihood of occurrence is fairly low.

iwehrman commented 9 years ago

@tiburbage Can you file a v1.2 Watson bug for this?

chadrolfs commented 9 years ago

No need @tiburbage there's already a watson bug for this (see above) and Jesper has already moved it to 1.2.