search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

modal dialog alert: Could not use pen tool because of a program error. #1681

Open chadrolfs opened 9 years ago

chadrolfs commented 9 years ago

New doc, select Rect tool and drag out a shape within AB, select the Pen tool and click once to set an anchor point, click on the Rectangle 1 shape in layers panel, (pen tool still selected) click on canvas.

Result: modal dialog alert: Could not use pen tool because of a program error.

on Win you may get this as well when you try to set focus the Rect in the layers panel: Uncaught TypeError: Cannot read property 'getBoundingClientRect' of undefined [Edit - Barkin: This is unrelated and fixed]

chadrolfs commented 9 years ago

After you click OK to the modal error dialog, if you set focus back to Shape 1 and click again, it will connect the first anchor point to the one you just set, essentially letting you continue to draw out the shape you started with the pen tool.

baaygun commented 9 years ago

barkin/1681, Not a fan of the transfer skip FIXME comment in there so leaving this Fix in Progress for now.

baaygun commented 9 years ago

I've fixed this in my branch... However, I think a better solution would be to start new pen layers instead of complaining about lack of use, which would make this a core bug. I'm still leaving my PR open to remedy the situation, but we should look into not needing that fix.

mcilroyc commented 8 years ago

I think @volfied is saying that this is fix fa realz now. @chadrolfs

chadrolfs commented 8 years ago

Following original steps in issue, I still get modal error dialog.

baaygun commented 8 years ago

Will be fixed in pgdv.max.672 with CL 1044284.

As a side effect, any time layer selection changes, we erase the current sub path index now, so to be able to continue an open path in the selected layer, you'll need to click one of it's open anchors to activate that sub path.

chadrolfs commented 8 years ago

Apparently the core fix broke things on the other side of the fence. They are reverting so this bug will once again re-occur. Thanks to @fosterbrereton for the heads up. Here is the core issue: http://moriarty.corp.adobe.com/bug?bug=4071562

chadrolfs commented 8 years ago

Yep, it's back and I don't think we have time to come up with a solution. For discussion. I'm recommending kick to M4.

chadrolfs commented 8 years ago

https://watsonexp.corp.adobe.com//#bug=4075258

tiburbage commented 8 years ago

The Watson entry relating to this issue has been closed. We can revisit as a JIRA if it warrants that.