Layer and Document models

adobe-photoshop / spaces-design

Adobe Photoshop Design Space

http://adobe-photoshop.github.io/

Other

852 stars 74 forks source link

Layer and Document models #30

Closed DesignSpaceBot closed 9 years ago

DesignSpaceBot commented 9 years ago

Tests are not fixed yet, but this is the proposed models for current functionality we have of layers and documents. @iwehrman, have fun!

-- @volfied at 2014-09-30T20:51:57Z

DesignSpaceBot commented 9 years ago

@iwehrman Fixed the unit tests, only change was DOCUMENT_UPDATE returning documentID instead of document object.

-- @volfied at 2014-09-30T21:08:04Z

DesignSpaceBot commented 9 years ago

Leaving note per our discussion:

Will implement LayerTree.js model, that keeps track of the layer structure in a document. This model will be responsible for different ways of accessing the layers (layerset, layer array etc), and a Document model will contain a LayerTree model.
On document update, document store will wait for layer store, layer store will create the LayerTree model from the raw layer array, and save it to it's own id->LayerTree map. Document store will grab the layer tree from the layer store, and attach it to the Document model. This way each store only deals with the models it's named after.

-- @volfied at 2014-09-30T21:40:26Z

DesignSpaceBot commented 9 years ago

@iwehrman , added the new model, please review.

-- @volfied at 2014-10-01T17:53:28Z

DesignSpaceBot commented 9 years ago

Back to you @volfied :tennis:. One nit and one possibly contentious suggestion.

-- @iwehrman at 2014-10-01T18:54:51Z

DesignSpaceBot commented 9 years ago

Also, why is your username @volfied?

-- @iwehrman at 2014-10-01T18:54:59Z

DesignSpaceBot commented 9 years ago

nitty gritty. Now selections are stored in the document model, and are being queried by <Layer> components as state.

-- @volfied at 2014-10-01T20:29:20Z

DesignSpaceBot commented 9 years ago

OK, done with this pass. Mostly nits and some additional questions/suggestions about future improvements. (I.e., not explicitly tracking depth and ultimately other unnecessary state.)

-- @iwehrman at 2014-10-01T21:33:15Z

DesignSpaceBot commented 9 years ago

Oops, I guess I Shouldn't have rebased... git is still confusing.

-- @volfied at 2014-10-02T19:54:18Z

DesignSpaceBot commented 9 years ago

Well I can't read this diff any more so I guess I'll just merge it!

-- @iwehrman at 2014-10-02T22:06:01Z