search

adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
852 stars 74 forks source link

Format non-finite values in NumberInput #3552

Closed iwehrman closed 8 years ago

iwehrman commented 8 years ago

Currently NumberInput throws if its value is a non-finite number. It's hard to prevent this from ever happening, so instead I'm just changing NumberInput to format a non-finite number as the empty string instead of throwing.

This is vaguely related to #3542.

baaygun commented 8 years ago

I think we should put a log.warn in there to track the cause issues.

baaygun commented 8 years ago

@iwehrman looks great, but I'd like to leave a note in there to remind us something gone wrong.

iwehrman commented 8 years ago

Fixed. Back to @volfied.