adobe-photoshop / spaces-design

Adobe Photoshop Design Space
http://adobe-photoshop.github.io/
Other
853 stars 74 forks source link

For scrubbing position, use absolute values #3555

Closed baaygun closed 8 years ago

baaygun commented 8 years ago

While scrubbing, we would wrongfully pass the coalesce flag as the translate flag into _getMoveLayerActions, this was causing all scrubs besides the first one to be absolute, and cause the issue seen in #3536

To fix this issue, I first fixed the flag being passed while scrubbing. However, we still had the problems that if we set absolute position while scrubbing, we would get huge jumps as the layer is being scrubbed across artboard boundaries. So we now use the absolute bounds of the layer to calculate where to scrub it next, which correctly scrubs the layer across boundaries.

Addresses #3536

iwehrman commented 8 years ago

LGTM!